Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixed single column links bug #17601

Merged
merged 2 commits into from
Apr 3, 2020
Merged

fix(ui): fixed single column links bug #17601

merged 2 commits into from
Apr 3, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Apr 3, 2020

Closes #16924

Problem

URL parsing for table results with 1 column would apply funky styling to the results.

Solution

I genuinely can't say why the previous implementation was failing. The regex statement was able to parse a URL correctly when multiple columns were present, but the second only 1 column was present, the regex statement failed to parse the URL correctly. After investigating it for a while, I genuinely couldn't a valid reason why it would be failing to parse the values correctly. As such, I switched the initial validation to use a native JS method to validate whether the value is a URL based on the regex parsing that was previously being used to validate the string.

table-column-fix

  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested a review from drdelambre April 3, 2020 15:11
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope!

@asalem1 asalem1 merged commit 207f174 into master Apr 3, 2020
@asalem1 asalem1 deleted the fix/table-links-bug branch April 3, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in table graphs not working correctly with highlights
2 participants