chore(ui): move users & about nav items #17849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavarius
changed the title
mavarius
changed the title
mavarius
force-pushed
the
refactor/org-nav-items
branch
from
e08860b
to
268d31c
Compare
mavarius
changed the title
mavarius
force-pushed
the
refactor/org-nav-items
branch
from
b431bfe
to
d85947b
Compare
alexpaxton
suggested changes
Apr 23, 2020
CHANGELOG.md
Outdated
Comment on lines
13
to
15
| 1. [17849](https://github.com/influxdata/influxdb/pull/17849): Move Organization navigation items to user menu. | ||
| 1. [17714](https://github.com/influxdata/influxdb/pull/17714): Cloud environments no longer render markdown images, for security reasons. | ||
| 1. [17321](https://github.com/influxdata/influxdb/pull/17321): Improve UI for sorting resources | ||
| 1. [17740](https://github.com/influxdata/influxdb/pull/17740): Add single-color color schemes for visualizations |
There was a problem hiding this comment.
nit: i think we append to the bottom not the top. not that it's a very big deal
Suggested change
| 1. [17849](https://github.com/influxdata/influxdb/pull/17849): Move Organization navigation items to user menu. | |
| 1. [17714](https://github.com/influxdata/influxdb/pull/17714): Cloud environments no longer render markdown images, for security reasons. | |
| 1. [17321](https://github.com/influxdata/influxdb/pull/17321): Improve UI for sorting resources | |
| 1. [17740](https://github.com/influxdata/influxdb/pull/17740): Add single-color color schemes for visualizations | |
| 1. [17714](https://github.com/influxdata/influxdb/pull/17714): Cloud environments no longer render markdown images, for security reasons. | |
| 1. [17321](https://github.com/influxdata/influxdb/pull/17321): Improve UI for sorting resources | |
| 1. [17740](https://github.com/influxdata/influxdb/pull/17740): Add single-color color schemes for visualizations | |
| 1. [17849](https://github.com/influxdata/influxdb/pull/17849): Move Organization navigation items to user menu. |
There was a problem hiding this comment.
Ya, here's the Quartz PR: https://github.com/influxdata/quartz/pull/2530
| linkElement={className => ( | ||
| <a | ||
| className={className} | ||
| href={`${CLOUD_URL}/organizations/${org.id}${CLOUD_USERS_PATH}`} |
There was a problem hiding this comment.
what's up with /orgs/ and /organizations/?
There was a problem hiding this comment.
This is the route we ended up within Quartz, there's discussions ongoing around syncing this and users/members but that's outside the scope of this PR.
|
@mavarius can you throw some screenshots of the changes in here? |
|
Might want to rename |
|
Actually, disregard my last comment |
lukevmorris
suggested changes
Apr 27, 2020
No changes need to be made to the routes, only the UI elements. "Members" is only renamed to "Users" in cloud, not OSS. |
mavarius
force-pushed
the
refactor/org-nav-items
branch
from
e665249
to
5028b8a
Compare
lukevmorris
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17578