Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(variable-hydration): fixed variable overhydration issue #18346

Merged
merged 11 commits into from
Jun 8, 2020
Merged

fix(variable-hydration): fixed variable overhydration issue #18346

merged 11 commits into from
Jun 8, 2020

Commits on Jun 8, 2020

  1. fix(findSubgraph): updated findSubgraph to return subgraphs that only… 

    … have 1 reference to a node no matter how deeply nested

Still need to update the filterUnusedVars function to load variables that might be called within variables
Also need to determine whether a child node in a graph can have multiple parents
    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    5042b05 View commit details
    Browse the repository at this point in the history

  2. fix(hydrateVars.test): fixed the breaking tests. 

    Need to figure out whether some of the tests are still necessary.
Need to find out whether a child can have multiple parents
Need to find out whether a parent with multiple children should hydrate all the children
Need to work on the filterUnusedVars
    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    26be172 View commit details
    Browse the repository at this point in the history

  3. feat(hydratevars): added feature flag to revert any potential issue w… 

    …ith implementation
    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    4bebd6a View commit details
    Browse the repository at this point in the history

  4. feat(wip): this is a WIP, need to account for parent's children and a… 

    …m unsure where to go. Need to take a break from variables
    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    686d196 View commit details
    Browse the repository at this point in the history

  5. feat(findSubgraph): completed findSubgraph logic to account for uniqu… 

    …e constraints around parent/child relationships

Added/updated tests to ensure feature stability
Need to resolve filterUnusedVariables issues
    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    53499bd View commit details
    Browse the repository at this point in the history

  6. feat(filterUnusedVars): turns out this works great with the new subgr… 

    …aph implementation so I removed the comment

also add the featureflag back to the feature
    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    8ebb352 View commit details
    Browse the repository at this point in the history

  7. chore(changelog): updated the changelog and updated the featureflag d… 

    …efault
    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    e25d1b4 View commit details
    Browse the repository at this point in the history

  8. feat(hydrateVars.test): conditionally check hydrateVars result length… 

    … based on featureFlag

This is a temporary workaround until the featureflag can be removed so that the tests pass
    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    1335474 View commit details
    Browse the repository at this point in the history

  9. fix(tests): conditionally render the tests based on the featureFlag

    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    ff5a8ee View commit details
    Browse the repository at this point in the history

  10. fix(test): conditionally rendering last hydrateVars test

    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    57319d6 View commit details
    Browse the repository at this point in the history

  11. chore(changelog): updated CHANGELOG PR

    @asalem1
    asalem1 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    332bb51 View commit details
    Browse the repository at this point in the history