feat(pkger): allow for base github content urls for json/yaml/jsonnet templates #18541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
requested review from
imogenkinsman,
hoorayimhelping and
bthesorceror
and removed request for
a team
hoorayimhelping
approved these changes
Jun 16, 2020
hoorayimhelping
approved these changes
Jun 16, 2020
… templates closes: #18479
jsteenb2
force-pushed
the
18479/pkger_allow_simple_github_urls
branch
from
3851b0e
to
8fb1f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #18479
preview, can now provide the github.com link: