feat(influx): provide for remote files in the template commands #18546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawkode
approved these changes
Jun 16, 2020
jsteenb2
force-pushed
the
influx/allow_remote_files
branch
2 times, most recently
from
0d60647
to
257292f
Compare
jsteenb2
force-pushed
the
influx/allow_remote_files
branch
from
257292f
to
2453432
Compare
sanderson
reviewed
Jun 16, 2020
cmd/influx/pkg.go
Outdated
| @@ -816,11 +817,12 @@ func (b *cmdPkgBuilder) registerPkgPrintOpts(cmd *cobra.Command) { | |||
| } | |||
|
|
|||
| func (b *cmdPkgBuilder) registerPkgFileFlags(cmd *cobra.Command) { | |||
| cmd.Flags().StringSliceVarP(&b.files, "file", "f", nil, "Path to template file") | |||
| cmd.Flags().StringSliceVarP(&b.files, "file", "f", nil, "Path to template file; A https scheme will provide a remote file and a file scheme or missing scheme will be interpreted as a file") | |||
There was a problem hiding this comment.
A https scheme will provide a remote file and a file scheme or missing scheme will be interpreted as a file
Supports HTTP(S) URLs or file paths.
jsteenb2
force-pushed
the
influx/allow_remote_files
branch
from
2453432
to
1de5291
Compare
jsteenb2
force-pushed
the
influx/allow_remote_files
branch
from
1de5291
to
0388a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rawkode you have been heard