feat(influx): extend influx stacks cmd with update #18573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
changed the title
jsteenb2
force-pushed
the
18548/influx_update_stack_cmd
branch
from
3af9503
to
1a56ed3
Compare
bthesorceror
approved these changes
Jun 17, 2020
sanderson
requested changes
Jun 17, 2020
cmd/influx/pkg.go
Outdated
| cmd := b.newCmdStackList("stacks") | ||
| cmd.Short = "List stack(s) and associated templates. Sub commands are useful for managing stacks." | ||
| cmd.Long = ` | ||
| List stack(s) and associated templates. Sub commands are useful for managing stacks. |
There was a problem hiding this comment.
Sub commands are useful for managing stacks. -> Subcommands manage stacks.
cmd/influx/pkg.go
Outdated
Comment on lines
836
to
840
| # Initialize a stack with a name and description | ||
| influx stack update -n $STACK_NAME -d $STACK_DESCRIPTION | ||
|
|
||
| # Initialize a stack with a name and urls to associate with stack. | ||
| influx stack update -n $STACK_NAME -u $PATH_TO_TEMPLATE |
There was a problem hiding this comment.
Do these initialize stacks or just update existing stacks? These should also include a stack ID since it's a required parameter.
There was a problem hiding this comment.
ahhh good point, totally forgot that 🤦
jsteenb2
force-pushed
the
18548/influx_update_stack_cmd
branch
from
1a56ed3
to
1b464f0
Compare
jsteenb2
force-pushed
the
18548/influx_update_stack_cmd
branch
from
1b464f0
to
9ee415f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18548