fix(timeseries-map-bug): prevents random racecondition bug from erroring cells #18632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18312
Problem
Cells would randomly error out after creation because the query that was created was undefined
Solution
After some investigating, it seems like this issue is a race condition that makes it hard to reproduce consistently. I investigated the origin of the queries property that's being passed in and everything seems to indicate that queries should be there. As such, I'm not quite sure where this bug actually exists (that queries are undefined in the map dispatch to props), but adding this statement should allow us to prevent the cell from erroring out.