chore(query Builder): fix query builder state #18649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to change redux state to queryBuilder
…ipt editor and navigating to another page
… list leads to the data explorer page with query builder
rbose22
force-pushed
the
rashi-switching-to-query-builder
branch
from
476a113
to
6c9d4e4
Compare
hoorayimhelping
approved these changes
Jun 23, 2020
ui/cypress/e2e/explorer.test.ts
Outdated
| cy.getByTestID('nav-item-data-explorer').click() | ||
|
|
||
| cy.get('.flux-editor').within(() => { | ||
| cy.get('.view-lines').contains(fluxCode).should('exist') |
There was a problem hiding this comment.
you can safely drop the should('exist') if it follows a contains function. https://docs.cypress.io/guides/core-concepts/introduction-to-cypress.html#Default-Assertions
would
cy.contains(fluxCode)work? or does this need to be scoped to .view-lines?
if you can just find fluxCode anywhere, this can be simplified to
Suggested change
| cy.get('.view-lines').contains(fluxCode).should('exist') | |
| cy..contains(fluxCode) |
| @@ -155,7 +159,7 @@ export const loadBuckets = () => async ( | |||
| const orgID = getOrg(getState()).id | |||
|
|
|||
| dispatch(setBuilderBucketsStatus(RemoteDataState.Loading)) | |||
|
|
|||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18120
Originally, when a user begins writing in the script editor in the explore page and then navigates to the data page and clicks on one of the buckets, the user is taken to the explore page, but the script editor is still visible instead of the query builder. This solution updates the redux state of the explore page, so that when navigating from the data page to the explore page, the query builder is always displayed.
This change does not affect navigation from any other pages. For example, if the user was using the script editor on the explore page and then navigated to the tasks page, when they return to the explore page, the script editor will still be visible instead of the query builder.