Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove kv Session service and sessionsv1 bucket #18823

Merged
merged 2 commits into from Jul 2, 2020
Merged

chore: remove kv Session service and sessionsv1 bucket #18823

merged 2 commits into from Jul 2, 2020

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Jul 1, 2020 •
edited

This removes the bucket sessionv1 from the underlying metadata store.
It does so using a migration.

It marks the sessionsv1 bucket in kv as deprecated.

It also removes the now defunct session code.
The top-level sessions package handles this now (along with the sessionv2 bucket).

@GeorgeMac GeorgeMac force-pushed the gm/delete-sessionsv1-migration branch from 80698c7 to 3fda325 Compare July 1, 2020 17:27
@GeorgeMac GeorgeMac changed the title chore: remove sessionsv1 bucket chore: remove kv Session service and sessionsv1 bucket Jul 1, 2020
@GeorgeMac GeorgeMac requested review from a team and docmerlin and removed request for a team July 1, 2020 17:29
@brettbuddin brettbuddin requested review from brettbuddin and removed request for docmerlin July 1, 2020 17:32
brettbuddin
brettbuddin approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@brettbuddin brettbuddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any concerns about deploying this? I can imagine for clusters like us-west-2 we would need to be careful about mass-deletion in the keyspace.

@GeorgeMac
Copy link
Contributor Author

I did indeed. In cloud the delete is a no op 👍
But this does stop it from getting warmed in the cache.

@GeorgeMac GeorgeMac merged commit 4a6bc1d into master Jul 2, 2020
@GeorgeMac GeorgeMac deleted the gm/delete-sessionsv1-migration branch July 2, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettbuddin brettbuddin brettbuddin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeorgeMac @brettbuddin