feat(ui): redesign asset & rate limit alerts #19032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavarius
force-pushed
the
feat/rate-bulletins
branch
from
89e5c73
to
973b753
Compare
mavarius
changed the title
|
@bpalani fyi |
ischolten
approved these changes
Jul 23, 2020
| className={className} | ||
| > | ||
| <Alert icon={IconFont.Cloud} color={ComponentColor.Primary}> | ||
| const AssetLimitAlert: FC<Props> = ({limitStatus, resourceName, className}) => { |
|
|
||
| return renamedResources.join(' and ') | ||
| } | ||
| return null |
There was a problem hiding this comment.
is this return null needed?
There was a problem hiding this comment.
This returns null if not CLOUD
| padding: 0 $page-gutter; | ||
| padding-bottom: 16px; | ||
| max-width: 1608px; | ||
| .cf-page-control-bar { |
There was a problem hiding this comment.
unrelated to code: why are changes sometimes highlighted?
There was a problem hiding this comment.
It usually highlights it if the entire line/block didn't change but some parts of it did.
mavarius
force-pushed
the
feat/rate-bulletins
branch
from
9e7faff
to
4c50a2a
Compare
mavarius
force-pushed
the
feat/rate-bulletins
branch
from
533d115
to
32c9046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rate Limit Alert
Asset Limit Alert
