Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(influx): add active-config flag to override config on single command call #19334

Merged
merged 1 commit into from
Aug 14, 2020
Merged

feat(influx): add active-config flag to override config on single command call #19334

merged 1 commit into from
Aug 14, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Aug 14, 2020 •
edited
Loading

closes: #19318

sanderson
sanderson approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion

cmd/influx/main.go Outdated Show resolved Hide resolved
russorat
russorat approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteenb2 jsteenb2 merged commit c0b593e into master Aug 14, 2020
@jsteenb2 jsteenb2 deleted the 19318/influx_active_config branch August 14, 2020 20:33
@sanderson sanderson mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderson sanderson sanderson approved these changes

@russorat russorat russorat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: ability to specify a config profile as a flag
3 participants
@jsteenb2 @sanderson @russorat