Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement DELETE FROM and DROP MEASUREMENT #19549

Merged
merged 2 commits into from Sep 11, 2020
Merged

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Sep 10, 2020

Closes #19416

This PR implements the DELETE FROM and DROP MEASUREMENT statements for InfluxQL, to ensure feature parity with InfluxQL support in Cloud. The implementation of these changes is in commit 0b59f8a.

This PR also includes a commit that does some housekeeping to consolidate some mock types for unit tests that appeared verbatim in separate packages.

Take the opportunity to combines duplicated types in both packages
under the root `internal` package
@stuartcarnie stuartcarnie added area/influxql Issues related to InfluxQL query language area/2.x OSS 2.0 related issues and PRs labels Sep 10, 2020
@stuartcarnie stuartcarnie requested a review from a team September 10, 2020 22:14
@stuartcarnie stuartcarnie self-assigned this Sep 10, 2020
@stuartcarnie stuartcarnie requested review from jacobmarble and removed request for a team September 10, 2020 22:37
@stuartcarnie stuartcarnie merged commit 8576d1d into master Sep 11, 2020
@stuartcarnie stuartcarnie deleted the sgc/issue/19416 branch September 11, 2020 18:37
@stuartcarnie stuartcarnie mentioned this pull request Sep 16, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/influxql Issues related to InfluxQL query language area/2.x OSS 2.0 related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement InfluxQL DELETE and DROP MEASUREMENT
2 participants