fix(templates): preserve cell colors on export/import #19700
Conversation
glinton
requested review from
hoorayimhelping,
a team and
kristinarobinson
and removed request for
a team and
hoorayimhelping
| @@ -977,6 +977,7 @@ const ( | |||
| ) | |||
|
|
|||
| type color struct { | |||
| ID string `json:"id,omitempty" yaml:"id,omitempty"` | |||
There was a problem hiding this comment.
just checking that there shouldn't be a situation where the ID would empty / 0, right?
There was a problem hiding this comment.
swagger shouldn't need to be updated as this is only preserving the already present color id. it was previously getting dropped and it appears the ui relies on it (no console errors though) to be set to show that color (it's been base in every dashboard i looked at).
There was a problem hiding this comment.
if it is empty, it would be when applying an old export where the id was not set with the color information. the color would still appear broken because i didn't default empty id's to "base", but if the user fixes the color and re-exports, the color would be preserved by this change.
Closes #19441
Something relies on the ID of the cell's color to be set (seems like
"base"is a common id). This PR preserves that color ID accross import/export so one can now export and re-import a dashboard and any custom colors in cells should go unchanged.