feat(authorization): Create a v1 authorization service #19815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
force-pushed
the
sgc/issues/19812
branch
from
ec3b82e
to
a53d217
Compare
This service is a private API for managing authorization tokens for v1 API requests. Note that this commit does not hook up the service to the v1 `/query` and `/write`, which will occur in a subsequent PR. Closes #19812
stuartcarnie
force-pushed
the
sgc/issues/19812
branch
from
a53d217
to
da40bf3
Compare
4 tasks
GeorgeMac
approved these changes
Oct 27, 2020
Correct – I figured that code did mostly what we needed. I considered if there were ways to abstract some of the implementation, but then considered it was likely to cause more problems, if the two diverged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19812
This PR introduces a new package,
v1/authorization, that provides an implementation ofinfluxdb.AuthorizationServicefor managing v1 authorization tokens. It is a private API, exposed via/private/legacy/authorizations, with the same operations as/api/v2/authorizationsfor creating, reading, updating and deleting data.Note that this commit does not hook up the service to the v1
/queryand/write, which will occur in a subsequent PR .