feat: add tick generation properties and legendColorizeRows #19839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCL735
requested review from
zoesteinkamp and
glinton
and removed request for
a team
glinton
approved these changes
Oct 27, 2020
This was referenced Oct 29, 2020
3 tasks
Can you please say more? What is the problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on work to influxdata/giraffe#79 and influxdata/giraffe#317
Mirrors idpe pull 9027
Adds properties for storing the user's selections for tick generation, including a
generateAxisTicksproperty that will turn on/off the entire feature regardless of the numeric values of the other properties.Also adds the
legendColorizeRowsproperty to allow the user to toggle color on/off in the legend.