fix: enable write-only users to pass auth checks in the V1 API #19945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I manually tested this along with a hacky fix for #19949. Am open to suggestions for automated tests, the change to |
danxmoran
commented
Nov 9, 2020
stuartcarnie
previously requested changes
Nov 9, 2020
danxmoran
requested review from
stuartcarnie
and removed request for
benbjohnson
danxmoran
force-pushed
the
dm-dbrp-permissions-19944
branch
from
f98123d
to
5ae1c29
Compare
danxmoran
force-pushed
the
dm-dbrp-permissions-19944
branch
from
5ae1c29
to
44c1d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19944
Our V1 auth layer allows for write-only users, but our V1 write-path requires looking up buckets via DBRP mappings. That lookup currently performs multiple checks for bucket-read permission, causing failures.