Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upgrade): use db/rp naming convention when upgrading DBs #19952

Merged
merged 2 commits into from
Nov 9, 2020
Merged

fix(upgrade): use db/rp naming convention when upgrading DBs #19952

merged 2 commits into from
Nov 9, 2020

Conversation

danxmoran
Copy link
Contributor

@danxmoran danxmoran commented Nov 9, 2020 •
edited
Loading

Closes #19951

Use / instead of - to separate DB and RP when upgrading to 2.x buckets. The comments & error messages were already using /.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

stuartcarnie
stuartcarnie approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it – easy win!

russorat
russorat approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope!

@danxmoran danxmoran merged commit b4aa582 into master Nov 9, 2020
@danxmoran danxmoran deleted the dm-slash-pls-19951 branch November 9, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartcarnie stuartcarnie stuartcarnie approved these changes

@russorat russorat russorat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

influxd upgrade names buckets "<db>-<rp>" instead of "<db>/<rp>"
3 participants
@danxmoran @stuartcarnie @russorat