fix(cmd/influxd): validate all input paths to upgrade up-front
#20012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
force-pushed
the
dm-upgrade-ux-improvements-19985
branch
from
28fdc26
to
4db1fac
Compare
stuartcarnie
approved these changes
Nov 12, 2020
This was referenced Nov 13, 2020
danxmoran
added a commit
that referenced
this pull request
Nov 16, 2020
8 tasks
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19985
Validate existence / nonexistence of source and target paths provided to the
upgradecommand before doing any work, to avoid annoyance.