feat(cmd/influxd): export 1.x continuous queries as part of upgrade #20039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Nov 13, 2020
danxmoran
commented
Nov 13, 2020
There was a problem hiding this comment.
Awaiting @timhallinflux's comments on the format of the file. My preference is to write the queries only.
danxmoran
force-pushed
the
dm-upgrade-write-continuous-queries-19985
branch
from
97a4ba8
to
f66165c
Compare
2 tasks
danxmoran
added a commit
that referenced
this pull request
Nov 16, 2020
8 tasks
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
danxmoran
added a commit
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19985
Write CQs to disk as databases are upgraded. The issue didn't describe an encoding scheme for the exported queries. I went with TSV as I expected that tab wouldn't clash with the content of the queries themselves, but I'm not sure if it's the most useful option.