Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): dbrp cli #20067

Merged
merged 5 commits into from
Nov 17, 2020
Merged

feat(cli): dbrp cli #20067

merged 5 commits into from
Nov 17, 2020

Conversation

docmerlin
Copy link
Contributor

Closes #19950

This adds DBRP management to the CLI.

@danxmoran danxmoran self-requested a review November 17, 2020 13:55
@danxmoran
Copy link
Contributor

Will take a deeper look later, but low-hanging fruit to start: can you add a line to the CHANGELOD.md?

@danxmoran
Copy link
Contributor

Failed gotest seems(?) unrelated, I opened #20069 to track it

danxmoran
danxmoran reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Higher-level questions:

  • Would it make sense to unit-test any piece of this?
  • Are the errors returned by the server sane enough to return directly from the CLI, or should we wrap them with friendlier messages?

cmd/influx/v1_dbrp.go Outdated Show resolved Hide resolved
cmd/influx/v1_dbrp.go Show resolved Hide resolved
cmd/influx/v1_dbrp.go Outdated Show resolved Hide resolved
cmd/influx/v1_dbrp.go Show resolved Hide resolved
cmd/influx/v1_dbrp.go Show resolved Hide resolved
cmd/influx/v1_dbrp.go Show resolved Hide resolved
cmd/influx/v1_dbrp.go Outdated Show resolved Hide resolved
cmd/influx/v1_dbrp.go Show resolved Hide resolved
cmd/influx/v1_dbrp.go Outdated Show resolved Hide resolved
danxmoran
danxmoran reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing

cmd/influx/v1_dbrp.go Outdated Show resolved Hide resolved
danxmoran
danxmoran approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when CI passes

@danxmoran danxmoran merged commit 478d25e into master Nov 17, 2020
@docmerlin docmerlin deleted the cli/dbrp branch November 17, 2020 20:15
danxmoran added a commit that referenced this pull request Nov 17, 2020
@docmerlin @danxmoran
feat(cmd/influx): Add DBRP cli commands as influx v1 dbrp (#20067)
0ca021f 
Co-authored-by: Dan Moran <dmoran@influxdata.com>
danxmoran added a commit that referenced this pull request Nov 17, 2020
@docmerlin @danxmoran
feat(cmd/influx): Add DBRP cli commands as influx v1 dbrp (#20067)
beaaa55 
Co-authored-by: Dan Moran <dmoran@influxdata.com>
@noramullen1 noramullen1 mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxmoran danxmoran danxmoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dbrp management to the CLI
2 participants
@docmerlin @danxmoran