-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(models): grow tag index buffer if needed #20137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @foobar, I've reproduced the bug locally, and your patch does seem to fix it! I left some suggestions for clarifying the code comments. Could you also:
- Add a line to the CHANGELOG.md describing the fix?
- Add a regression test to
models/points_test.go
?
ac2c2e2
to
0d27648
Compare
0d27648
to
cab8788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again for the contribution
@@ -1255,6 +1255,17 @@ func TestParsePointWithDuplicateTags(t *testing.T) { | |||
} | |||
} | |||
|
|||
func TestParsePointWithVariousTags(t *testing.T) { | |||
line := "m" | |||
for i := 0; i < 1000; i++ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test!
(cherry picked from commit cae1417)
Closes #20136