fix(kv): add KV migration to repair DBRP mappings broken by schema change #20168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
force-pushed
the
dm-ugprade-repair-dbrps
branch
from
53bf493
to
592d0fd
Compare
|
Marking as draft while I convert the logic to a KV migration (thanks for the idea @stuartcarnie!) |
danxmoran
force-pushed
the
dm-ugprade-repair-dbrps
branch
from
1194304
to
2830bf3
Compare
danxmoran
force-pushed
the
dm-ugprade-repair-dbrps
branch
from
2830bf3
to
b6a16c0
Compare
danxmoran
commented
Nov 25, 2020
| // repair DBRP owner and bucket IDs | ||
| Migration0013_RepairDBRPOwnerAndBucketIDs, | ||
| // reindex DBRPs | ||
| Migration0014_ReindexDBRPs, |
There was a problem hiding this comment.
The reindex here is required for the Find methods in the DBRP service to locate repaired DBRPs. Reordering the migrations so my new Migration0013 runs before the existing Migration0012 also works, but that felt like a potentially-dangerous idea.
danxmoran
commented
Nov 25, 2020
| "github.com/influxdata/influxdb/v2/kv" | ||
| ) | ||
|
|
||
| var Migration0013_RepairDBRPOwnerAndBucketIDs = UpOnlyMigration( |
There was a problem hiding this comment.
The logic & structure of this file is largely copied from the 0012 migration.
|
To test this change, I:
|
danxmoran
changed the title
GeorgeMac
approved these changes
Nov 25, 2020
danxmoran
added a commit
that referenced
this pull request
Nov 25, 2020
This was referenced Dec 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20167
I tested the new command locally, happy to refactor and set up automated tests if the reviewers would like.