Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure init.d-style install sees our default environment variables #20349

Merged
merged 3 commits into from
Dec 16, 2020

Conversation

danxmoran
Copy link
Contributor

@danxmoran danxmoran commented Dec 15, 2020

Addresses #20132

I think the set trick will work since the shebang on the script points at /bin/bash, let me know if it's not portable.

Tested by building the package & installing into a fresh ubuntu VM. Without these changes, I see this in the logs:

ts=2020-12-15T22:52:12.224551Z lvl=info msg="Resources opened" log_id=0R69W2FG000 service=bolt path=/var/lib/influxdb/.influxdbv2/influxd.bolt

After this change, I see:

ts=2020-12-15T22:56:05.258672Z lvl=info msg="Resources opened" log_id=0R69jGY0000 service=bolt path=/var/lib/influxdb/influxd.bolt

With these env / config file contents:

$ cat /etc/default/influxdb2
INFLUXD_CONFIG_PATH=/etc/influxdb/config.toml

$ cat /etc/influxdb/config.toml
bolt-path = "/var/lib/influxdb/influxd.bolt"
engine-path = "/var/lib/influxdb/engine"

Copy link
Contributor

@psteinbachs psteinbachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be fine and shouldn't pose any portability issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants