Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't duplicate text in task errors #20380

Merged
merged 2 commits into from
Dec 21, 2020
Merged

fix: don't duplicate text in task errors #20380

merged 2 commits into from
Dec 21, 2020

Conversation

danxmoran
Copy link
Contributor

Closes #20055

docmerlin
docmerlin approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@docmerlin docmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool, looks like the Error() method takes care of including the Err field, so we should be good.

@danxmoran danxmoran merged commit 1b48c32 into master Dec 21, 2020
@danxmoran danxmoran deleted the dm-fix-dup-err-text-20055 branch December 21, 2020 18:21
dubsky pushed a commit to dubsky/influxdb that referenced this pull request Dec 22, 2020
@danxmoran @dubsky
fix: don't duplicate text in task errors (influxdata#20380)
c67ecc4
@danxmoran danxmoran mentioned this pull request Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@docmerlin docmerlin docmerlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InfluxDB 2.0.1 OSS; duplicated error message
2 participants
@danxmoran @docmerlin