fix(cmd/influxd): improve influxd upgrade logging, and require manual confirmation of data copy
#20440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Jan 6, 2021
| return fmt.Sprintf(`Proceeding will copy all V1 data to %q | ||
| Space available: %s | ||
| Space required: %s | ||
| `, v2dir, freeBytes, requiredBytes) |
There was a problem hiding this comment.
@psteinbachs @timhallinflux can you give a 👍 or 👎 to this behavior change? It adds one more y/N interaction point to influxd upgrade, to force users to consider how much disk they're about to use. The check is skipped if the --force flag is given.
There was a problem hiding this comment.
Yes, given community feedback around this I think it is a welcome change.
psteinbachs
requested review from
psteinbachs
and removed request for
psteinbachs
danxmoran
force-pushed
the
dm-upgrade-improve-logging-20383
branch
from
9b9f0ca
to
4b5f9e1
Compare
danxmoran
force-pushed
the
dm-upgrade-improve-logging-20383
branch
from
4b5f9e1
to
310d112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20383
Before this patch, we were:
verbosemodeAfter this patch:
verboseis deprecated/hidden in favor of debug-level logging (reduce the number of levers users need to pull to get useful diagnostics)--force)