feat(cmd/influxd): add nats-max-payload-bytes config option to influxd
#20564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
force-pushed
the
dm-nats-max-payload-conf-19713
branch
from
cbe5e9f
to
dfe15ed
Compare
davidby-influx
approved these changes
Jan 20, 2021
5 tasks
wallyqs
reviewed
Jan 20, 2021
| @@ -18,6 +18,7 @@ import ( | |||
| "github.com/influxdata/influxdb/v2/storage" | |||
| "github.com/influxdata/influxdb/v2/v1/coordinator" | |||
| "github.com/influxdata/influxdb/v2/vault" | |||
| natsserver "github.com/nats-io/gnatsd/server" | |||
There was a problem hiding this comment.
heads up that this is still v1 of the server for v2, this would be needed:
"github.com/nats-io/nats-server/v2/server"
(it is backwards compatible as well)
danxmoran
added a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19713
I went with raw bytes instead of a
toml.Sizefor simplicity, but I could be convinced to change it.