SHOW DIAGNOSTICS command

[otoolep]

No description provided.

[otoolep]

I think it's important the server object get this stuff, so it be dumped by the diags. I am open to other approaches.

[otoolep]

Making this more table-driven, stand by.

[otoolep]

Table-driven code put in place. Green build.

[otoolep]

$ curl -G 'http://localhost:8086/query?pretty=true' --data-urlencode "q=SHOW DIAGNOSTICS"
{
    "results": [
        {
            "series": [
                {
                    "name": "build",
                    "columns": [
                        "time",
                        "commitHash",
                        "version"
                    ],
                    "values": [
                        [
                            "2015-03-24T16:26:45.190882079Z",
                            "unknown",
                            "0.9"
                        ]
                    ]
                },
                {
                    "name": "server",
                    "columns": [
                        "time",
                        "authEnabled",
                        "id",
                        "index",
                        "numShards",
                        "path",
                        "retentionAutoCreate"
                    ],
                    "values": [
                        [
                            "2015-03-24T16:26:45.190882079Z",
                            false,
                            1,
                            7,
                            1,
                            "/home/philip/.influxdb/data",
                            true
                        ]
                    ]
                },
                {
                    "name": "cq",
                    "columns": [
                        "time",
                        "lastRun"
                    ],
                    "values": [
                        [
                            "2015-03-24T16:26:45.190882079Z",
                            "0001-01-01T00:00:00Z"
                        ]
                    ]
                },
                {
                    "name": "system",
                    "columns": [
                        "time",
                        "arch",
                        "hostname",
                        "numcpu",
                        "os",
                        "pid",
                        "startTime",
                        "uptime"
                    ],
                    "values": [
                        [
                            "2015-03-24T16:26:45.190882079Z",
                            "amd64",
                            "marx",
                            8,
                            "linux",
                            6047,
                            "2015-03-24T16:26:41.947782722Z",
                            "3.243141953s"
                        ]
                    ]
                },
                {
                    "name": "memory",
                    "columns": [
                        "time",
                        "alloc",
                        "frees",
                        "heapAlloc",
                        "heapIdle",
                        "heapInUse",
                        "heapObjects",
                        "heapReleased",
                        "heapSys",
                        "lookups",
                        "mallocs",
                        "numGC",
                        "pauseTotalNs",
                        "sys",
                        "totalAlloc"
                    ],
                    "values": [
                        [
                            "2015-03-24T16:26:45.190882079Z",
                            548528,
                            9525,
                            548528,
                            737280,
                            884736,
                            3009,
                            0,
                            1622016,
                            147,
                            12534,
                            9,
                            4487713,
                            3999992,
                            1531200
                        ]
                    ]
                },
                {
                    "name": "go",
                    "columns": [
                        "time",
                        "goMaxProcs",
                        "numGoroutine",
                        "version"
                    ],
                    "values": [
                        [
                            "2015-03-24T16:26:45.190882079Z",
                            1,
                            41,
                            "go1.4"
                        ]
                    ]
                },
                {
                    "name": "shardGroups",
                    "columns": [
                        "time",
                        "database",
                        "retentionPolicy",
                        "id",
                        "startTime",
                        "endTime",
                        "duration",
                        "numShards"
                    ],
                    "values": [
                        [
                            "2015-03-24T16:26:45.190882079Z",
                            "internal",
                            "default",
                            1,
                            "2015-03-23T00:00:00Z",
                            "2015-03-30T00:00:00Z",
                            "168h0m0s",
                            1
                        ]
                    ]
                },
                {
                    "name": "shards",
                    "columns": [
                        "time",
                        "id",
                        "dataNodes",
                        "index",
                        "path"
                    ],
                    "values": [
                        [
                            "2015-03-24T16:26:45.190882079Z",
                            1,
                            "1",
                            8,
                            "/home/philip/.influxdb/data/shards/1"
                        ]
                    ]
                }
            ]
        }
    ]
}

[toddboom]

👍

Very exciting!

[benbjohnson]

I think it'd be easier to use this data from a client or another system if it were a type:

type Diagnostics struct {
    Build struct {
        Version    string `json:"version"`
        CommitHash string `json:"commitHash"`
    } `json:"build"`

    Server struct {
        ID          string `json:"id"`
        Path        string `json:"path"`
        AuthEnabled bool   `json:"authenticationEnabled"`
        ...
    }
}

And then you can get the current Diagnostics type using NewDiagnostics(). That would shorten this function quite a bit.

[benbjohnson]

Or maybe name it Stats instead -- similar to MemStats.

[otoolep]

I was thinking about something along those lines this morning, but it wasn't clear exactly what to do.

The Diagnostics type needs information from various components -- the server, build information, Go runtime, indexes. Which part of the code fills in the values? I want to do something like this, as I want to factor out this code next so that it can be written to the database (like the stats) every minute or so.

Let me know what you have in mind, as I was going to something like this next.