-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor for tasks backport #21117
Conversation
No changelog for refactors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same nitpick applied repeatedly
authorizer/authorize_find.go
Outdated
@@ -3,6 +3,8 @@ package authorizer | |||
import ( | |||
"context" | |||
|
|||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like imports needed cleaned up in general here
authorizer/check.go
Outdated
@@ -3,6 +3,8 @@ package authorizer | |||
import ( | |||
"context" | |||
|
|||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
authorizer/task.go
Outdated
@@ -4,6 +4,8 @@ import ( | |||
"context" | |||
"fmt" | |||
|
|||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
checks/service.go
Outdated
@@ -4,6 +4,8 @@ import ( | |||
"context" | |||
"fmt" | |||
|
|||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
checks/service_external_test.go
Outdated
@@ -8,6 +8,8 @@ import ( | |||
"testing" | |||
"time" | |||
|
|||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
task/backend/task.go
Outdated
@@ -4,29 +4,29 @@ import ( | |||
"context" | |||
"time" | |||
|
|||
"github.com/influxdata/influxdb/v2/kit/platform" | |||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
task/mock/executor.go
Outdated
@@ -7,15 +7,16 @@ import ( | |||
"sync" | |||
"time" | |||
|
|||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
task/mock/task_control_service.go
Outdated
@@ -7,9 +7,10 @@ import ( | |||
"sync" | |||
"time" | |||
|
|||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
task/servicetest/servicetest.go
Outdated
@@ -16,6 +16,8 @@ import ( | |||
"testing" | |||
"time" | |||
|
|||
"github.com/influxdata/influxdb/v2/task/taskmodel" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
task/taskmodel/task_test.go
Outdated
|
||
import ( | ||
"encoding/json" | ||
"github.com/influxdata/influxdb/v2/task/taskmodel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup imports
Remove some dead code, and move the FluxLanguageService interface to the fluxlang package.