Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redundant registration for prometheus collector metrics #21156

Merged
merged 1 commit into from Apr 7, 2021
Merged

fix: redundant registration for prometheus collector metrics #21156

merged 1 commit into from Apr 7, 2021

Conversation

lesam
Copy link
Contributor

@lesam lesam commented Apr 7, 2021 •
edited

Fixup for #17212

@lesam
Copy link
Contributor Author

lesam commented Apr 7, 2021

Before the recent changes, there were no prometheus collectors to register so this did not matter. Now the prometheus collectors are registered in a registry specific to the server so they should not be in the global registry.

@lesam lesam requested a review from danxmoran April 7, 2021 16:15
@lesam lesam merged commit fed8ca1 into influxdata:master-1.x Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxmoran danxmoran danxmoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lesam @danxmoran