Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add StaticLegend #21218

Merged
merged 7 commits into from
Apr 15, 2021
Merged

feat: add StaticLegend #21218

merged 7 commits into from
Apr 15, 2021

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Apr 15, 2021 •
edited

Closes #21154

  • Removes unused, conflicting, and confusing references to "Legend"
  • Adds a collection of properties for the Static Legend which is a new feature for the UI
  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr) - documented in Giraffe
  • Signed CLA (if not already signed)

@TCL735 TCL735 requested a review from a team as a code owner April 15, 2021 00:02
@glinton glinton mentioned this pull request Apr 15, 2021
Merged
@TCL735
Copy link
Contributor Author

TCL735 commented Apr 15, 2021

force push was to rebase on master

@TCL735
Copy link
Contributor Author

TCL735 commented Apr 15, 2021

Ready for review.

@TCL735
Copy link
Contributor Author

TCL735 commented Apr 15, 2021

force push to resolve merge conflicts

@TCL735
Copy link
Contributor Author

TCL735 commented Apr 15, 2021

ready for review

danxmoran
danxmoran approved these changes Apr 15, 2021
View reviewed changes
http/swagger.yml
@@ -8938,7 +8938,6 @@ components:
- shape
- axes
- colors
- legend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

staticLegend doesn't replace it as required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Static Legend is not required.

@TCL735 TCL735 merged commit 0c88854 into master Apr 15, 2021
@TCL735 TCL735 deleted the feat_21154_static_legend branch April 15, 2021 22:06
@TCL735 TCL735 mentioned this pull request May 7, 2021
Closed
@kelseiv kelseiv mentioned this pull request Oct 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxmoran danxmoran danxmoran approved these changes

@jrenee42 jrenee42 Awaiting requested review from jrenee42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static Legend: update swagger
2 participants
@TCL735 @danxmoran