feat(users): list users via the API now supports offset, limit or after parameter
#21367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
approved these changes
May 11, 2021
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| 1. [19811](https://github.com/influxdata/influxdb/pull/19811): Add Geo graph type to be able to store in Dashboard cells. | |||
| 1. [21218](https://github.com/influxdata/influxdb/pull/21218): Add the properties of a static legend for line graphs and band plots. | |||
| 1. [21367](https://github.com/influxdata/influxdb/pull/21367): List users via the API now supports `offset`, `limit` or `after` parameter. | |||
There was a problem hiding this comment.
Also mention descending here?
Or maybe something more general like List users via the API now supports pagination
There was a problem hiding this comment.
I've changed it to general version: List users via the API now supports pagination.
| @@ -404,11 +404,19 @@ func (h *UserHandler) handleGetUsers(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| type getUsersRequest struct { | |||
| filter influxdb.UserFilter | |||
| opts influxdb.FindOptions | |||
There was a problem hiding this comment.
I was going to suggest we not bother supporting offset, but if it's already bundled into this then it's probably easier to leave it.
|
Hrm, I think the build failure is an unrelated bug in our logic to detect & avoid running certain CI steps from fork-PRs... will investigate |
… `after` parameter Signed-off-by: Jakub Bednar <jakub.bednar@gmail.com>
Signed-off-by: Jakub Bednar <jakub.bednar@gmail.com>
… `after` parameter Signed-off-by: Jakub Bednar <jakub.bednar@gmail.com>
Signed-off-by: Jakub Bednar <jakub.bednar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21402
Related to influxdata/influxdb-client-csharp#190
List users via the API now supports
offset,limitorafterparameter