Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode toml durations correctly #2145

Merged
merged 3 commits into from
Apr 2, 2015
Merged

Encode toml durations correctly #2145

merged 3 commits into from
Apr 2, 2015

Conversation

corylanou
Copy link
Contributor

Fixes #2144

@corylanou corylanou self-assigned this Apr 2, 2015
@corylanou
Copy link
Contributor Author

Durations are now encoded properly. Running influxd config will give you this now:

hostname = "Corys-MacBook-Pro.local"
bind-address = ""
reporting-disabled = false

[initialization]
  join-urls = ""

[authentication]
  enabled = false

[admin]
  enabled = true
  port = 8083

[api]
  port = 0
  ssl-port = 0
  ssl-cert = ""
  read-timeout = "0"

[collectd]
  address = ""
  port = 0
  database = ""
  enabled = false
  typesdb = ""

[udp]
  enabled = false
  bind-address = ""
  port = 0

[broker]
  port = 8086
  dir = "/Users/corylanou/.influxdb/broker"
  election-timeout = "1s"

[data]
  dir = "/Users/corylanou/.influxdb/data"
  port = 8086
  retention-auto-create = true
  retention-check-enabled = true
  retention-check-period = "10m0s"
  retention-create-period = "45m0s"

[Snapshot]
  enabled = true
  bind-address = "127.0.0.1"
  port = 8087

[cluster]
  dir = ""

[logging]
  write-tracing = false
  raft-tracing = false

[Statistics]
  enabled = false
  database = "_internal"
  retention-policy = "default"
  write-interval = "1m0s"

[continuous_queries]
  recompute-previous-n = 2
  recompute-no-older-than = "10m0s"
  compute-runs-per-interval = 10
  compute-no-more-than = "2m0s"
  disable = false

## v0.9.0-rc19 [unreleased]

### Bugfixes
- [#2145](https://github.com/influxdb/influxdb/pull/2145): Encode toml durations correctly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this something like "...which fixes default configuration generation."

@otoolep
Copy link
Contributor

otoolep commented Apr 2, 2015

+1, minor suggestion re changelog.

corylanou added a commit that referenced this pull request Apr 2, 2015
@corylanou corylanou merged commit d29a77e into master Apr 2, 2015
@corylanou corylanou removed the review label Apr 2, 2015
@corylanou corylanou deleted the fix-toml-duration branch April 2, 2015 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Influxd config does not export durations properly
2 participants