Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/influx): accept --input flag in restore command #21477

Merged
merged 4 commits into from
May 14, 2021

Conversation

danxmoran
Copy link
Contributor

Closes #21475

--input has been effectively useless up until now, but all of the examples in our public docs show using it instead of the positional arg.

I chose to deprecate --input instead of the arg because influx backup uses a positional arg to specify the path where backup data should be stored, and it felt intuitive to have symmetry between the two.

@williamhbaker williamhbaker self-requested a review May 14, 2021 17:48
restore/restore.go Outdated Show resolved Hide resolved
Copy link
Contributor

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

influx restore requires a single positional argument even when --input is specified
2 participants