Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/influxd): Add logging work-around for absolute file paths on Windows #21540

Merged
merged 6 commits into from
May 24, 2021

Conversation

danxmoran
Copy link
Contributor

Closes #21534

I tested this manually, waiting on the original reporter's feedback to confirm that the fix works for them too.

Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks correct, and I offer a non-blocking refactoring suggestion to consider.

cmd/influxd/upgrade/logging_windows.go Outdated Show resolved Hide resolved
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration 1.x to 2.0.x fails on Windows : couldn't open sink
2 participants