feat: Port influxd inspect verify-tombstone subcommand #21646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesam
reviewed
Jun 9, 2021
lesam
reviewed
Jun 9, 2021
danxmoran
reviewed
Jun 16, 2021
serenibyss
force-pushed
the
inspect-verify-tombstone
branch
from
0591683
to
fd8d21f
Compare
danxmoran
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19538
This PR ports the
./influxd inspect verify-tombstonesubcommand. Similar to other ported commands, the logic of the verification itself is largely unchanged, with the majority of the changes in porting to Cobra and writing test cases. I'd like to point out at this point that the global structs and functions in thecmd/influxd/inspectpackage are starting to collide, so we should maybe break these commands into their own packages.