fix: remove incorrect optimization for group-by #21691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danxmoran is there a good place to add an end-to-end select test (would the grace tests be the right place for that?) |
|
@lesam I'd vote for adding a new test to either You'd be the first person adding a test since Stuart ported the suite over from IDPE so you might hit some warts, but I think the overall framework is solid. |
lesam
commented
Jun 15, 2021
| @@ -88,6 +89,45 @@ func TestServer_Query_Chunked(t *testing.T) { | |||
| test.Run(ctx, t, s) | |||
| } | |||
|
|
|||
| // Ensure a more complex group-by is correct | |||
| func TestServer_Query_ComplexGroupby(t *testing.T) { | |||
There was a problem hiding this comment.
This test fails with the fastIdx 'optimisation'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21639