Allow http write handler to decode gzipped body #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add an integration test, but we have a bash script for now to validate that it worked. Will add an integration test in a future PR. Need to get this merged for now. |
| @@ -485,6 +499,7 @@ func (h *Handler) serveWrite(w http.ResponseWriter, r *http.Request, user *influ | |||
| writeError(influxdb.Result{Err: err}, http.StatusInternalServerError) | |||
| return | |||
| } else { | |||
| w.WriteHeader(http.StatusOK) | |||
There was a problem hiding this comment.
I don't think we were ever returning 200 properly before, not sure how I didn't catch this.
There was a problem hiding this comment.
If you don't call it at all, 200 is returned, right?
|
+1, assuming you ran the test script against the change, of course. |
corylanou
force-pushed
the
http-gzip-posts
branch
from
a64878f
to
13f318b
Compare
corylanou
added a commit
that referenced
this pull request
Apr 7, 2015
Allow http write handler to decode gzipped body
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
Add support for get /api/v2/query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we supported streaming out gzip'ed responses, but we had not implemented the ability to post gzipped json to our write endpoint.