Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port influxd inspect build-tsi #21936

Merged
merged 5 commits into from
Jul 27, 2021
Merged

feat: port influxd inspect build-tsi #21936

merged 5 commits into from
Jul 27, 2021

Conversation

mcfarlm3
Copy link
Contributor

@mcfarlm3 mcfarlm3 commented Jul 23, 2021

Closes #19529

Ports the influx inspect build-tsi subcommand to 2.x. Optional flags to filter by database and retention were replaced with an optional bucket-id flag. dataPath and walPath are now optional flags instead of required, so a user can specify custom paths, but otherwise it will use the default paths for these.

@mcfarlm3 mcfarlm3 requested a review from danxmoran July 23, 2021 15:17
cmd/influxd/inspect/build_tsi/build_tsi.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/build_tsi/build_tsi.go Outdated Show resolved Hide resolved
@mcfarlm3 mcfarlm3 requested a review from danxmoran July 27, 2021 15:05
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style comment, but LGTM overall

"sync/atomic"

"go.uber.org/zap/zapcore"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra space, needs removed & imports re-sorted

@mcfarlm3 mcfarlm3 merged commit 9f13f1c into master Jul 27, 2021
@jacobmarble jacobmarble deleted the inspect-build-tsi branch January 2, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port influxd inspect build-tsi command
2 participants