Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add route to delete individual secret #21938

Merged
merged 1 commit into from
Jul 23, 2021
Merged

chore: add route to delete individual secret #21938

merged 1 commit into from
Jul 23, 2021

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Jul 23, 2021 •
edited
Loading

This adds a route to delete individual secrets in preparation to remove the old post to /secrets/delete route.

@joelfried
Copy link

Thank you for getting this up so quickly! ❤️

@williamhbaker
Copy link
Contributor

Looks additive and straightfoward...sounds like this is part of something changing in the UI with regard to handling secrets?

@joelfried
Copy link

Looks additive and straightfoward...sounds like this is part of something changing in the UI with regard to handling secrets?

I have a PR up for UI to add Secrets and this endpoint on the OSS side brings parity between OSS and Cloud.

williamhbaker
williamhbaker approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@glinton glinton merged commit f9914e8 into master Jul 23, 2021
@glinton glinton deleted the chore/11243 branch July 23, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelfried joelfried joelfried approved these changes

@williamhbaker williamhbaker williamhbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glinton @joelfried @williamhbaker