Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster fix #2217

Merged
merged 2 commits into from
Apr 9, 2015
Merged

Cluster fix #2217

merged 2 commits into from
Apr 9, 2015

Conversation

benbjohnson
Copy link
Contributor

Overview

This pull request provides two fixes:

  1. There's a zero length message check that doesn't need to exist now that we have checksums.
  2. We were overwriting votes in some cases which may be causing the stale term issue.

@benbjohnson
Remove zero-length data panic from messaging.Conn.
47fa90f 
This check is no longer necessary as the checksum added
to the messaging.Message will catch any data errors.
@benbjohnson
Only update term if higher in candidate loop.
37829ea 
This fixes a bug where votes were overwritten because terms were
being reset by incoming terms that were the same.
@toddboom
Copy link
Contributor

toddboom commented Apr 9, 2015

makes sense to me - :shipit:

@corylanou
Copy link
Contributor

+1

benbjohnson added a commit that referenced this pull request Apr 9, 2015
@benbjohnson
Merge pull request #2217 from influxdb/cluster-fix
7815d47 
Cluster fix
@benbjohnson benbjohnson merged commit 7815d47 into master Apr 9, 2015
@benbjohnson benbjohnson deleted the cluster-fix branch April 9, 2015 17:52
@otoolep
Copy link
Contributor

otoolep commented Apr 9, 2015

Let's not forget the CHANGELOG for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benbjohnson @toddboom @corylanou @otoolep