fix: for Windows, copy snapshot files being backed up #22551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, make copies of files for snapshots, because Go does not support the FILE_SHARE_DELETE flag which allows files (and links) to be deleted while open. This causes temporary directories to be left behind after backups. closes #16289
|
This should get backported to 1.8 |
lesam
reviewed
Sep 22, 2021
| ) | ||
|
|
||
| // copyOrLink - allow substitution of a file copy for a hard link when running on Windows systems. | ||
| func copyOrLink(oldPath, newPath string) error { |
There was a problem hiding this comment.
It might be more straightforward to just check runtime.GOOS == "windows", but this is fine
There was a problem hiding this comment.
That was my original implementation, but reading various Go blogs convinced me conditional compilation was more idiomatic.
lesam
reviewed
Sep 22, 2021
| if _, err := io.Copy(wfd, rfd); err != nil { | ||
| return fmt.Errorf("unable to copy file for backup from %s to %s: %q", oldPath, newPath, err) | ||
| } | ||
| if err := os.Chtimes(newPath, fi.ModTime(), fi.ModTime()); err != nil { |
There was a problem hiding this comment.
Kind of ugly that Chtimes takes aTime here but only exposes reading ModTime in a cross-platform way - might be worth a comment
lesam
approved these changes
Sep 22, 2021
davidby-influx
added a commit
that referenced
this pull request
Sep 22, 2021
On Windows, make copies of files for snapshots, because Go does not support the FILE_SHARE_DELETE flag which allows files (and links) to be deleted while open. This causes temporary directories to be left behind after backups. closes #16289 (cherry picked from commit 3702fe8) closes #22557 (cherry picked from commit 47007f6)
davidby-influx
added a commit
that referenced
this pull request
Sep 22, 2021
… (#22563) On Windows, make copies of files for snapshots, because Go does not support the FILE_SHARE_DELETE flag which allows files (and links) to be deleted while open. This causes temporary directories to be left behind after backups. closes #16289 (cherry picked from commit 3702fe8) closes #22557 (cherry picked from commit 47007f6) closes #22558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, make copies of files for snapshots, because
Go does not support the FILE_SHARE_DELETE flag which
allows files (and links) to be deleted while open. This
causes temporary directories to be left behind after
backups.
closes #16289