ensure directory of pidfile exists after a restart #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
d'oh! missed rc25 😏 |
|
also, credit to http://serverfault.com/a/463743/234227 |
|
Looks good. We should also remove creation of the directory from packaging.sh, since this covers everything. |
|
hmm... i'm not sure how my changes relate to the test failure |
|
@neonstalwart -- we are currently debugging some CI failures that are not related to your change. They are afflicting our builds every so often for an unknown reason. We will definitely merge your change once we are happy it's not the cause (which I am sure this one isn't). |
|
This looks perfect -- thanks @neonstalwart |
otoolep
added a commit
that referenced
this pull request
Apr 15, 2015
ensure directory of pidfile exists after a restart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/var/run on ubuntu is a tmpfs so /var/run/influxdb is lost after a reboot and the influxdb user does not have permission to create that directory. this ensures that the directory exists by creating it in the init script
fixes #2273