Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually scheduled task runs now run when expected #23664

Merged
merged 5 commits into from
Oct 13, 2022

Conversation

jeffreyssmith2nd
Copy link
Contributor

Description

When creating a manual run of a task with a scheduledFor time, it was executing immediately rather than at that time. This fixes that behavior.

Context

This brings it in line with Cloud2 behavior as well as operating as a user would expect.

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

Copy link
Contributor

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, and code looks good!

@jeffreyssmith2nd jeffreyssmith2nd merged commit a0f1184 into master Oct 13, 2022
@jeffreyssmith2nd jeffreyssmith2nd deleted the smith/scheduled-task branch October 13, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled Tasks Run Immediately
2 participants