fix: do not require remoteOrgID in remote config/creation request #23838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add another line to this file for 2.4? I think it should be the last migration before this one. https://github.com/influxdata/influxdb/blob/master/cmd/influxd/downgrade/downgrade.go#L39 |
I checked, the new line should be 7 since 6 and 7 came in during 2.4 |
jeffreyssmith2nd
approved these changes
Oct 25, 2022
For reasons that are unclear, when we changed the migrations sqlite started returning the rows in a different order. This was verified directly in sqlite, so the easiest solution is to sort the lists to make sure they're compared correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the hard requirement for a remote org ID in the remote configuration, as this is unnecessary for 1.x remote connections. Goes along with influxdata/influx-cli#451
Both already merged:
remoteOrgIDnot required for ENT connection openapi#583 and chore: fix requiredremoteOrgIDin remote creation req openapi#584Affected areas:
CLI command (
influx remote create)Note for reviewers:
Check the semantic commit type: