Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup codeowners file #23940

Merged
merged 1 commit into from
Nov 22, 2022
Merged

chore: cleanup codeowners file #23940

merged 1 commit into from
Nov 22, 2022

Conversation

jeffreyssmith2nd
Copy link
Contributor

Description

The code owners file no longer matched the org structure.

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

@jeffreyssmith2nd jeffreyssmith2nd merged commit ef098ac into master Nov 22, 2022
@jeffreyssmith2nd jeffreyssmith2nd deleted the smith/codeowners branch November 22, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgnorton dgnorton dgnorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffreyssmith2nd @dgnorton