fix: execute "compact-series-file" at startup (1.x) #24260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
requested changes
Jun 1, 2023
scripts/influxd-systemd-start.sh
Outdated
| echo "${BASH_REMATCH[1]}" ; return | ||
| fi | ||
| fi | ||
| done <<< "$(influxd config -config /etc/influxdb/influxdb.conf 2>/dev/null)" |
There was a problem hiding this comment.
Should /etc/influxdb/influxdb.conf be a constant/parameter that we use here and in the actual command line, so they can't get out of sync?
There was a problem hiding this comment.
The config is hard-coded on master-1.x: scripts/influxd-systemd-start.sh. I am unsure what supplying another -config <path> via INFLUXD_OPTS would do (override vs ignore vs error), but the behavior should be consistent with the call that starts the service.
There was a problem hiding this comment.
I tested it, if -config is supplied via INFLUXD_OPTS, the first will be overridden in favor of INFLUXD_OPTS.
davidby-influx
requested changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(From Issue Description:)
When the database is online for long periods and many deletes occur, the series files grow. Instead of deleting the series outright, a tombstone is written instead. We will execute influx_inspect buildtsi -compact-series-file at startup which should help alleviate this problem.