Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select distinct tag custom error #2622

Merged
merged 4 commits into from
May 20, 2015

Conversation

corylanou
Copy link
Contributor

Fixes #2612

@@ -702,7 +702,7 @@ func (m *MapReduceJob) processRawResults(values []*rawQueryMapOutput) *Row {
selectNames[0], selectNames[i] = selectNames[i], selectNames[0]
}
hasTime = true
break
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that one for me. ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch it, my pre-commit hook did and stopped me dead in my tracks ;-)

@toddboom
Copy link
Contributor

lgtm 👍 :shipit: 💃

corylanou added a commit that referenced this pull request May 20, 2015
…rror-2612

Select distinct tag custom error
@corylanou corylanou merged commit de77ee1 into master May 20, 2015
@corylanou corylanou deleted the select-distinct-tag-customer-error-2612 branch May 20, 2015 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query planner should validate distinct is passed a field
2 participants