Re-enable Graphite support #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
reenable_graphite
branch
10 times, most recently
from
d3bdcee
to
34ec70f
Compare
|
+1 |
| @@ -156,6 +156,7 @@ func (s *Server) appendGraphiteService(c graphite.Config) { | |||
| return | |||
| } | |||
| srv := graphite.NewService(c) | |||
| srv.PointsWriter = s.PointsWriter | |||
Remove obsolete Graphite files
otoolep
force-pushed
the
reenable_graphite
branch
from
34ec70f
to
715ea76
Compare
|
|
||
| func (s *Service) Host() string { | ||
| return s.host | ||
| } |
There was a problem hiding this comment.
Can you expose this as:
func (s *Service) Addr() net.Addr
|
Overall it lgtm. Mostly minor feedback. |
otoolep
force-pushed
the
reenable_graphite
branch
from
715ea76
to
4769d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the existing Graphite input as a Service-style component.
Originally there was support for both UDP and TCP inputs, abstracted via a factory-like pattern. This was difficult to integrate with the new
Serviceinterface, so instead the the GraphiteServicetype simply switches on the configured protocol when opening and closing the Service. Depending on the configured protocol, it simply opens or closes a TCP or UDP server.This also had the nice side-effect of removing a bunch of duplicated code and attributes in the older TCP and UDP types.