fix #2944: don't require WHERE time on create CQ #2985
Conversation
dgnorton
changed the title
dgnorton
changed the title
|
+1 |
dgnorton
force-pushed
the
cq-nowhere-2944
branch
2 times, most recently
from
1cc5344
to
89e9716
Compare
| @@ -153,6 +153,7 @@ func (s *Service) backgroundLoop() { | |||
| return | |||
| case <-s.RunCh: | |||
| if s.MetaStore.IsLeader() { | |||
| s.Logger.Print("running continuous queries by request") | |||
There was a problem hiding this comment.
You want this logging message?
There was a problem hiding this comment.
Since CQs are usually run by the service, I thought it would be good to log a message if they were triggered by an external request instead.
There was a problem hiding this comment.
Agreed -- that does make sense, and I wanted to be sure that's what it was. +1
|
How does this actually fix the issue? It's not clear to me. |
|
Closed in error. |
|
@otoolep it fixes it by storing the |
|
OK, makes sense -- thanks @dgnorton. +1 |
| @@ -244,13 +244,16 @@ func NewTestService(t *testing.T) *Service { | |||
|
|
|||
| // Set Logger to write to dev/null so stdout isn't polluted. | |||
| //null, _ := os.Open(os.DevNull) | |||
| s.Logger = log.New(os.Stdout, "", 0) | |||
| //s.Logger = log.New(os.Stdout, "", 0) | |||
There was a problem hiding this comment.
You want this commented out?
dgnorton
force-pushed
the
cq-nowhere-2944
branch
from
89e9716
to
6cbb605
Compare
fix #2944: don't require WHERE time on create CQ
No description provided.