Remove unnecessary timeout in WaitForLeader() #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CircleCI failure, I kicked the build. |
|
This build failure seems real, and I believe the code needs further work. |
If the timer expires and a leader is still not selected, the local data node will never be created.
cannium
force-pushed
the
remove-unnecessary-timeout
branch
from
dc29f99
to
c41ef86
Compare
|
It's strange I can build the prior code successfully. The tests should pass this time. |
|
Thanks @cannium @benbjohnson -- does this make sense to you? |
|
this is roughly the fix i had that resolved #3205 for me |
|
@nstott yep, same problem. |
|
@otoolep yes, this makes sense. I think the timeout was only meant to be temporary. |
|
OK, thanks @benbjohnson -- merging now. |
|
Thanks @cannium |
otoolep
added a commit
that referenced
this pull request
Jul 19, 2015
Remove unnecessary timeout in WaitForLeader()
|
Cherry-picked to 0.9.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timer expires and a leader is still not selected, the local data node will never be created.